PM / devfreq: imx-bus: Fix inconsistent IS_ERR and PTR_ERR
authorGustavo A. R. Silva <gustavoars@kernel.org>
Thu, 7 May 2020 13:12:45 +0000 (08:12 -0500)
committerChanwoo Choi <cw00.choi@samsung.com>
Thu, 28 May 2020 09:02:40 +0000 (18:02 +0900)
Fix inconsistent IS_ERR and PTR_ERR in imx_bus_init_icc().

The proper pointer to be passed as argument to PTR_ERR() is
priv->icc_pdev.

This bug was detected with the help of Coccinelle.

Fixes: 16c1d2f1b0bd ("PM / devfreq: imx: Register interconnect device")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
[cw00.choi: Edit the patch title from 'imx' to 'imx-bus']
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/devfreq/imx-bus.c

index 532e795..4f38455 100644 (file)
@@ -88,8 +88,8 @@ static int imx_bus_init_icc(struct device *dev)
                        dev, icc_driver_name, -1, NULL, 0);
        if (IS_ERR(priv->icc_pdev)) {
                dev_err(dev, "failed to register icc provider %s: %ld\n",
-                               icc_driver_name, PTR_ERR(priv->devfreq));
-               return PTR_ERR(priv->devfreq);
+                               icc_driver_name, PTR_ERR(priv->icc_pdev));
+               return PTR_ERR(priv->icc_pdev);
        }
 
        return 0;