memory: of: Fix refcount leak bug in of_lpddr3_get_ddr_timings()

We should add the of_node_put() when breaking out of
for_each_child_of_node() as it will automatically increase
and decrease the refcount.

Fixes: 976897dd96db ("memory: Extend of_memory with LPDDR3 support")
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220719085640.1210583-2-windhl@126.com

diff --git a/drivers/memory/of_memory.c b/drivers/memory/of_memory.c
index 8e2ef4bf6b17b82c55512b134ee8e605c834d5d1..fcd20d85d38574a7d98b42a48eb84b10b032199e 100644 (file)
--- a/drivers/memory/of_memory.c
+++ b/drivers/memory/of_memory.c
@@ -285,6 +285,7 @@ const struct lpddr3_timings
                if (of_device_is_compatible(np_tim, tim_compat)) {
                        if (of_lpddr3_do_get_timings(np_tim, &timings[i])) {
                                devm_kfree(dev, timings);
+                               of_node_put(np_tim);
                                goto default_timings;
                        }
                        i++;