INTERNAL: fix bug of common executable feature

filter any "get_pc_trunk" function in application instrumentation

Change-Id: I1d8cc2e99a41b2a1db430b479345dd2849e72c99
Signed-off-by: greatim <jaewon81.lim@samsung.com>

diff --git a/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/swap/communicator/Communicator30.java b/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/swap/communicator/Communicator30.java
index 73af2fa..7edc790 100755 (executable)
--- a/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/swap/communicator/Communicator30.java
+++ b/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/swap/communicator/Communicator30.java
@@ -197,7 +197,7 @@ public class Communicator30 extends BaseCommunicator {
                Logger.performance("TEST", "Start Trace", "Set application inst");
 
                if (userSpaceInst == null || userSpaceInst.getAppInstList().isEmpty()) {
-                       StartProcessManager.getInstance().setValue(100);
+                       StartProcessManager.getInstance().setValue(100);        // set progress bar to 100%
                        Logger.error("cannot get user space inst");
                        return HostResult.ERR_MSG_START_FAIL;
                }
@@ -403,7 +403,7 @@ public class Communicator30 extends BaseCommunicator {
                        AddrSymbolPair addrSymbol = symbols.get(i);
                        String symbol = addrSymbol.getSymbol();
                        // FIXME: black list hard coded.
-                       if (symbol.contains("__i686.get_pc_thunk")) {
+                       if (symbol.contains("get_pc_thunk")) {
                                continue;
                        }
 

diff --git a/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/ui/common/explorer/DeviceExplorer.java b/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/ui/common/explorer/DeviceExplorer.java
index 05a35a2..5a17d19 100644 (file)
--- a/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/ui/common/explorer/DeviceExplorer.java
+++ b/org.tizen.dynamicanalyzer/src/org/tizen/dynamicanalyzer/ui/common/explorer/DeviceExplorer.java
@@ -405,6 +405,8 @@ public class DeviceExplorer extends Composite {
                                        permission = permission | 1;
                                        break;
                                default:
+                                       // other letter is possible for permission string
+                                       // but it is not necessary to parsing
                                        break;
                                }
                        }