dt-bindings: power: Correct interrupt flags in examples
authorKrzysztof Kozlowski <krzk@kernel.org>
Tue, 8 Sep 2020 14:59:22 +0000 (16:59 +0200)
committerRob Herring <robh@kernel.org>
Tue, 15 Sep 2020 16:54:08 +0000 (10:54 -0600)
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW  = 1 = IRQ_TYPE_EDGE_RISING

Correct the interrupt flags, assuming the author of the code wanted some
logical behavior behind the name "ACTIVE_xxx", this is:
  ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200908145922.4502-1-krzk@kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
Documentation/devicetree/bindings/power/supply/act8945a-charger.txt

index c7dfb7c..cb737a9 100644 (file)
@@ -33,7 +33,7 @@ Example:
                        pinctrl-names = "default";
                        pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>;
                        interrupt-parent = <&pioA>;
-                       interrupts = <45 GPIO_ACTIVE_LOW>;
+                       interrupts = <45 IRQ_TYPE_LEVEL_LOW>;
 
                        active-semi,chglev-gpios = <&pioA 12 GPIO_ACTIVE_HIGH>;
                        active-semi,lbo-gpios = <&pioA 72 GPIO_ACTIVE_LOW>;