staging: wfx: remove misused call to cpu_to_le16()
authorJérôme Pouiller <jerome.pouiller@silabs.com>
Tue, 8 Oct 2019 09:42:59 +0000 (09:42 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 8 Oct 2019 12:41:14 +0000 (14:41 +0200)
Indeed, hif_msg->id is a uint8_t, so use of cpu_to_le16() is a madness.

Fixes: 9bca45f3d692 ("staging: wfx: allow to send 802.11 frames")
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20191008094232.10014-3-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wfx/data_tx.c

index 7f2799f..1891bca 100644 (file)
@@ -620,7 +620,7 @@ static int wfx_tx_inner(struct wfx_vif *wvif, struct ieee80211_sta *sta, struct
        memset(skb->data, 0, wmsg_len);
        hif_msg = (struct hif_msg *) skb->data;
        hif_msg->len = cpu_to_le16(skb->len);
-       hif_msg->id = cpu_to_le16(HIF_REQ_ID_TX);
+       hif_msg->id = HIF_REQ_ID_TX;
        hif_msg->interface = wvif->id;
        if (skb->len > wvif->wdev->hw_caps.size_inp_ch_buf) {
                dev_warn(wvif->wdev->dev, "requested frame size (%d) is larger than maximum supported (%d)\n",