Enforce policy: don't use *scanf functions.

* Makefile.maint (sc_prohibit_atoi_atof): Add to regexp and diagnostic.
* .x-sc_prohibit_atoi_atof: Give stty a temporary pass.
* TODO: note that stty.c needs this small clean-up.

diff --git a/.x-sc_prohibit_atoi_atof b/.x-sc_prohibit_atoi_atof
index 3aaffb2b560567714e22e55129639feac801cb25..a0d15bac0d29fa4f800aee4860337f2f130484f2 100644 (file)
--- a/.x-sc_prohibit_atoi_atof
+++ b/.x-sc_prohibit_atoi_atof
@@ -6,3 +6,5 @@ ChangeLog
 ^lib/euidaccess-stat\.c$
 ^lib/group-member\.c$
 ^Makefile\.maint$
+^doc/coreutils.texi$
+^src/stty.c$

diff --git a/ChangeLog b/ChangeLog
index 05bf2c8067ed2b147f07c5e8621e639f0e3bc187..2803f3f5be5d961e113306dbeeb367219dffbcd8 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2007-03-15  Jim Meyering  <jim@meyering.net>
+
+       Enforce policy: don't use *scanf functions.
+       * Makefile.maint (sc_prohibit_atoi_atof): Add to regexp and diagnostic.
+       * .x-sc_prohibit_atoi_atof: Give stty a temporary pass.
+       * TODO: note that stty.c needs this small clean-up.
+
 2007-03-13  Jim Meyering  <jim@meyering.net>
 
        Prepare to work on ACL-related failure when using Solaris ZFS.

diff --git a/Makefile.maint b/Makefile.maint
index c1da0d559ad3a32ba7363878acb73e2d6ae8a4b1..1c9d6971204c5e57f8f6ef975f0a8fd247d869c0 100644 (file)
--- a/Makefile.maint
+++ b/Makefile.maint
@@ -117,12 +117,12 @@ sc_space_tab:
          { echo '$(ME): found SPACE-TAB sequence; remove the SPACE'    \
                1>&2; exit 1; } || :
 
-# Don't use the old ato* functions in `real' code.
+# Don't use *scanf or the old ato* functions in `real' code.
 # They provide no error checking mechanism.
 # Instead, use strto* functions.
 sc_prohibit_atoi_atof:
-       @grep -nE '\<ato([filq]|ll)\>' $$($(CVS_LIST_EXCEPT)) &&        \
-         { echo '$(ME): do not use ato''f, ato''i, ato''l, ato''ll, or ato''q' \
+       @grep -nE '\<([fs]?scanf|ato([filq]|ll))\>' $$($(CVS_LIST_EXCEPT)) && \
+         { echo '$(ME): do not use *scan''f, ato''f, ato''i, ato''l, ato''ll, or ato''q'       \
                1>&2; exit 1; } || :
 
 # Using EXIT_SUCCESS as the first argument to error is misleading,

diff --git a/TODO b/TODO
index 61fe29c368ee277433f83cd99c073079c83018f1..0e626306a14d6b9c0c29d446bbe5c209a090a730 100644 (file)
--- a/TODO
+++ b/TODO
@@ -1,3 +1,6 @@
+stty.c:
+  use xstrtoul, not sscanf
+
 printf:
   Now that gnulib supports *printf("%a"), import one of the
   *printf-posix modules so that printf(1) will support %a even on