projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f0f4f79
)
scsi: nsp32: Call scsi_done() directly
author
Bart Van Assche
<bvanassche@acm.org>
Thu, 7 Oct 2021 20:28:53 +0000
(13:28 -0700)
committer
Martin K. Petersen
<martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:31:39 +0000
(21:31 -0400)
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.
Link:
https://lore.kernel.org/r/20211007202923.2174984-59-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/nsp32.c
patch
|
blob
|
history
diff --git
a/drivers/scsi/nsp32.c
b/drivers/scsi/nsp32.c
index
bc9d29e
..
1057b6f
100644
(file)
--- a/
drivers/scsi/nsp32.c
+++ b/
drivers/scsi/nsp32.c
@@
-945,7
+945,6
@@
static int nsp32_queuecommand_lck(struct scsi_cmnd *SCpnt,
show_command(SCpnt);
- SCpnt->scsi_done = done;
data->CurrentSC = SCpnt;
SCpnt->SCp.Status = SAM_STAT_CHECK_CONDITION;
scsi_set_resid(SCpnt, scsi_bufflen(SCpnt));
@@
-1546,7
+1545,7
@@
static void nsp32_scsi_done(struct scsi_cmnd *SCpnt)
/*
* call scsi_done
*/
-
(*SCpnt->scsi_done)
(SCpnt);
+
scsi_done
(SCpnt);
/*
* reset parameters