watchdog: core: stop watchdog when executing poweroff command
authorMeng Li <meng.li@windriver.com>
Mon, 14 Aug 2023 09:06:16 +0000 (17:06 +0800)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sat, 19 Aug 2023 15:36:19 +0000 (17:36 +0200)
On some platforms, for example, Intel SoC FPGA platform, the watchdog
is started in u-boot, and so kernel will create a timer and work to
keep watchdog alive. But when user executes commands "poweroff" or
"shutdown -h", the system is reset when watchdog triggers timeout even
if WDOG_STOP_ON_REBOOT is set in watchdog driver. The root cause is
that the watchdog is not stopped properly because the SYS_POWER_OFF case
is not supported in notify callback function. So, add this case to stop
watchdog when executing poweroff command.

Signed-off-by: Meng Li <Meng.Li@windriver.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230814090616.1853263-1-Meng.Li@windriver.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/watchdog_core.c

index d4c5a73..5b55cca 100644 (file)
@@ -161,7 +161,7 @@ static int watchdog_reboot_notifier(struct notifier_block *nb,
        struct watchdog_device *wdd;
 
        wdd = container_of(nb, struct watchdog_device, reboot_nb);
-       if (code == SYS_DOWN || code == SYS_HALT) {
+       if (code == SYS_DOWN || code == SYS_HALT || code == SYS_POWER_OFF) {
                if (watchdog_hw_running(wdd)) {
                        int ret;