mfd: twl4030-irq: Log an error in twl4030_sih_setup if the module cannot be found
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 25 May 2017 20:26:21 +0000 (22:26 +0200)
committerLee Jones <lee.jones@linaro.org>
Thu, 6 Jul 2017 07:29:11 +0000 (08:29 +0100)
As silently failing isn't that nice, emit an error message at a place
that was silent on failure up to now.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/twl4030-irq.c

index b46c0cf..378c02d 100644 (file)
@@ -638,8 +638,10 @@ int twl4030_sih_setup(struct device *dev, int module, int irq_base)
                }
        }
 
-       if (status < 0)
+       if (status < 0) {
+               dev_err(dev, "module to setup SIH for not found\n");
                return status;
+       }
 
        agent = kzalloc(sizeof(*agent), GFP_KERNEL);
        if (!agent)