bnxt_en: remove redundant debug register dma mem allocation
authorYueHaibing <yuehaibing@huawei.com>
Fri, 13 Jul 2018 03:02:04 +0000 (11:02 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 16 Jul 2018 20:37:38 +0000 (13:37 -0700)
hwrm_dbg_resp_addr and hwrm_dbg_resp_dma_addr are never used
and can be removed.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c
drivers/net/ethernet/broadcom/bnxt/bnxt.h

index d2dadad..2cf726e 100644 (file)
@@ -3012,13 +3012,6 @@ static void bnxt_free_hwrm_resources(struct bnxt *bp)
                          bp->hwrm_cmd_resp_dma_addr);
 
        bp->hwrm_cmd_resp_addr = NULL;
-       if (bp->hwrm_dbg_resp_addr) {
-               dma_free_coherent(&pdev->dev, HWRM_DBG_REG_BUF_SIZE,
-                                 bp->hwrm_dbg_resp_addr,
-                                 bp->hwrm_dbg_resp_dma_addr);
-
-               bp->hwrm_dbg_resp_addr = NULL;
-       }
 }
 
 static int bnxt_alloc_hwrm_resources(struct bnxt *bp)
@@ -3030,12 +3023,6 @@ static int bnxt_alloc_hwrm_resources(struct bnxt *bp)
                                                   GFP_KERNEL);
        if (!bp->hwrm_cmd_resp_addr)
                return -ENOMEM;
-       bp->hwrm_dbg_resp_addr = dma_alloc_coherent(&pdev->dev,
-                                                   HWRM_DBG_REG_BUF_SIZE,
-                                                   &bp->hwrm_dbg_resp_dma_addr,
-                                                   GFP_KERNEL);
-       if (!bp->hwrm_dbg_resp_addr)
-               netdev_warn(bp->dev, "fail to alloc debug register dma mem\n");
 
        return 0;
 }
index 9b14eb6..709ba86 100644 (file)
@@ -1287,9 +1287,6 @@ struct bnxt {
        dma_addr_t              hwrm_short_cmd_req_dma_addr;
        void                    *hwrm_cmd_resp_addr;
        dma_addr_t              hwrm_cmd_resp_dma_addr;
-       void                    *hwrm_dbg_resp_addr;
-       dma_addr_t              hwrm_dbg_resp_dma_addr;
-#define HWRM_DBG_REG_BUF_SIZE  128
 
        struct rx_port_stats    *hw_rx_port_stats;
        struct tx_port_stats    *hw_tx_port_stats;