[llvm-readobj] Remove duplicate inner if() condition. NFCI.
authorSimon Pilgrim <llvm-dev@redking.me.uk>
Tue, 27 Oct 2020 18:35:42 +0000 (18:35 +0000)
committerSimon Pilgrim <llvm-dev@redking.me.uk>
Tue, 27 Oct 2020 18:36:04 +0000 (18:36 +0000)
This should have been removed when rG445c3fdd2ae8 simplified the conditions.

Reported as "Snippet 5" in https://www.viva64.com/en/b/0771/

llvm/tools/llvm-readobj/ELFDumper.cpp

index 6bf0858..7a796ef 100644 (file)
@@ -4665,11 +4665,9 @@ void GNUStyle<ELFT>::printVersionSymbolSection(const Elf_Shdr *Sec) {
     Expected<StringRef> NameOrErr =
         this->dumper().getSymbolVersionByIndex(Ndx, IsDefault);
     if (!NameOrErr) {
-      if (!NameOrErr)
-        this->reportUniqueWarning(
-            createError("unable to get a version for entry " + Twine(I) +
-                        " of " + describe(this->Obj, *Sec) + ": " +
-                        toString(NameOrErr.takeError())));
+      this->reportUniqueWarning(createError(
+          "unable to get a version for entry " + Twine(I) + " of " +
+          describe(this->Obj, *Sec) + ": " + toString(NameOrErr.takeError())));
       Versions.emplace_back("<corrupt>");
       continue;
     }