IB/hfi1: Fix fall-through warnings for Clang
authorGustavo A. R. Silva <gustavoars@kernel.org>
Fri, 20 Nov 2020 18:25:27 +0000 (12:25 -0600)
committerJason Gunthorpe <jgg@nvidia.com>
Mon, 23 Nov 2020 19:54:10 +0000 (15:54 -0400)
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple break statements instead of just
letting the code fall through to the next case.

Link: https://lore.kernel.org/r/13cc2fe2cf8a71a778dbb3d996b07f5e5d04fd40.1605896059.git.gustavoars@kernel.org
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Tested-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/hfi1/qp.c
drivers/infiniband/hw/hfi1/tid_rdma.c

index 356518e..681bb4e 100644 (file)
@@ -339,6 +339,7 @@ int hfi1_setup_wqe(struct rvt_qp *qp, struct rvt_swqe *wqe, bool *call_send)
                        return -EINVAL;
                if (ibp->sl_to_sc[rdma_ah_get_sl(&ah->attr)] == 0xf)
                        return -EINVAL;
+               break;
        default:
                break;
        }
index 73d197e..92aa2a9 100644 (file)
@@ -2826,6 +2826,7 @@ static bool handle_read_kdeth_eflags(struct hfi1_ctxtdata *rcd,
                default:
                        break;
                }
+               break;
        default:
                break;
        }
@@ -3005,6 +3006,7 @@ bool hfi1_handle_kdeth_eflags(struct hfi1_ctxtdata *rcd,
                default:
                        break;
                }
+               break;
        default:
                break;
        }
@@ -3221,6 +3223,7 @@ bool hfi1_tid_rdma_wqe_interlock(struct rvt_qp *qp, struct rvt_swqe *wqe)
                        req = wqe_to_tid_req(prev);
                        if (req->ack_seg != req->total_segs)
                                goto interlock;
+                       break;
                default:
                        break;
                }
@@ -3239,9 +3242,11 @@ bool hfi1_tid_rdma_wqe_interlock(struct rvt_qp *qp, struct rvt_swqe *wqe)
                        req = wqe_to_tid_req(prev);
                        if (req->ack_seg != req->total_segs)
                                goto interlock;
+                       break;
                default:
                        break;
                }
+               break;
        default:
                break;
        }