net: netsec: remove superfluous if statement
authorIlias Apalodimas <ilias.apalodimas@linaro.org>
Tue, 9 Jul 2019 21:14:48 +0000 (00:14 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 9 Jul 2019 21:46:40 +0000 (14:46 -0700)
While freeing tx buffers the memory has to be unmapped if the packet was
an skb or was used for .ndo_xdp_xmit using the same arguments. Get rid
of the unneeded extra 'else if' statement

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/socionext/netsec.c

index c3a4f86..7f9280f 100644 (file)
@@ -654,12 +654,12 @@ static bool netsec_clean_tx_dring(struct netsec_priv *priv)
                eop = (entry->attr >> NETSEC_TX_LAST) & 1;
                dma_rmb();
 
-               if (desc->buf_type == TYPE_NETSEC_SKB)
+               /* if buf_type is either TYPE_NETSEC_SKB or
+                * TYPE_NETSEC_XDP_NDO we mapped it
+                */
+               if (desc->buf_type != TYPE_NETSEC_XDP_TX)
                        dma_unmap_single(priv->dev, desc->dma_addr, desc->len,
                                         DMA_TO_DEVICE);
-               else if (desc->buf_type == TYPE_NETSEC_XDP_NDO)
-                       dma_unmap_single(priv->dev, desc->dma_addr,
-                                        desc->len, DMA_TO_DEVICE);
 
                if (!eop)
                        goto next;