staging: mmal-vchiq: Make timeout a defined parameter
authorDave Stevenson <dave.stevenson@raspberrypi.org>
Mon, 29 Jun 2020 15:08:59 +0000 (17:08 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Jul 2020 13:45:22 +0000 (15:45 +0200)
The timeout period for VPU communications is a useful thing
to extend when debugging.
Set it via a define, rather than a magic number buried in the code.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Link: https://lore.kernel.org/r/20200629150945.10720-2-nsaenzjulienne@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c

index cbe262b..ebe7fb0 100644 (file)
  */
 #define VCHIQ_MMAL_MAX_COMPONENTS 64
 
+/*
+ * Timeout for synchronous msg responses in seconds.
+ * Helpful to increase this if stopping in the VPU debugger.
+ */
+#define SYNC_MSG_TIMEOUT       3
+
 /*#define FULL_MSG_DUMP 1*/
 
 #ifdef DEBUG
@@ -686,7 +692,7 @@ static int send_synchronous_mmal_msg(struct vchiq_mmal_instance *instance,
        }
 
        timeout = wait_for_completion_timeout(&msg_context->u.sync.cmplt,
-                                             3 * HZ);
+                                             SYNC_MSG_TIMEOUT * HZ);
        if (timeout == 0) {
                pr_err("timed out waiting for sync completion\n");
                ret = -ETIME;