regulator: mt6370: Use 'fwnode_gpiod_get_index' to fix gpio parsing
authorChiYuan Huang <cy_huang@richtek.com>
Wed, 29 Jun 2022 01:41:00 +0000 (09:41 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 29 Jun 2022 15:31:41 +0000 (16:31 +0100)
From the common binding, 'enable-gpio' or 'enable-gpios' are all well
for external 'enable' gpio.

'gpiod_get_from_of_node' only parse the 'enable' property, it need to
add the gpio suffix. It's more convenient to use fwnode_gpiod_get_index.
Although fwnode parsing is not preferred, but 'of_parse_cb' already can
guarantee the callback will only be used by regulator of_node parsing.

Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
Link: https://lore.kernel.org/r/1656466861-7737-1-git-send-email-u0084500@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/mt6370-regulator.c

index bc356b4..949b2c7 100644 (file)
@@ -153,7 +153,8 @@ static int mt6370_of_parse_cb(struct device_node *np,
        struct gpio_desc *enable_gpio;
        int ret;
 
-       enable_gpio = gpiod_get_from_of_node(np, "enable", 0, GPIOD_OUT_HIGH |
+       enable_gpio = fwnode_gpiod_get_index(of_fwnode_handle(np), "enable", 0,
+                                            GPIOD_OUT_HIGH |
                                             GPIOD_FLAGS_BIT_NONEXCLUSIVE,
                                             desc->name);
        if (IS_ERR(enable_gpio)) {