pinctrl: tegra: fix missing __iomem in suspend/resume
authorBen Dooks (Codethink) <ben.dooks@codethink.co.uk>
Wed, 18 Dec 2019 11:04:56 +0000 (11:04 +0000)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 6 Jan 2020 23:01:09 +0000 (00:01 +0100)
The functions should have __iomem on the register pointer
so add that to silence the following sparse warnings:

drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: warning: incorrect type in assignment (different address spaces)
drivers/pinctrl/tegra/pinctrl-tegra.c:657:22:    expected unsigned int [usertype] *regs
drivers/pinctrl/tegra/pinctrl-tegra.c:657:22:    got void [noderef] <asn:2> *
drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: warning: incorrect type in argument 1 (different address spaces)
drivers/pinctrl/tegra/pinctrl-tegra.c:659:42:    expected void const volatile [noderef] <asn:2> *addr
drivers/pinctrl/tegra/pinctrl-tegra.c:659:42:    got unsigned int [usertype] *
drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: warning: incorrect type in assignment (different address spaces)
drivers/pinctrl/tegra/pinctrl-tegra.c:675:22:    expected unsigned int [usertype] *regs
drivers/pinctrl/tegra/pinctrl-tegra.c:675:22:    got void [noderef] <asn:2> *
drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: warning: incorrect type in argument 2 (different address spaces)
drivers/pinctrl/tegra/pinctrl-tegra.c:677:25:    expected void volatile [noderef] <asn:2> *addr
drivers/pinctrl/tegra/pinctrl-tegra.c:677:25:    got unsigned int [usertype] *

Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
Link: https://lore.kernel.org/r/20191218110456.2533088-1-ben.dooks@codethink.co.uk
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/tegra/pinctrl-tegra.c

index 692d8b3..cefbbb8 100644 (file)
@@ -648,7 +648,7 @@ static int tegra_pinctrl_suspend(struct device *dev)
 {
        struct tegra_pmx *pmx = dev_get_drvdata(dev);
        u32 *backup_regs = pmx->backup_regs;
-       u32 *regs;
+       u32 __iomem *regs;
        size_t bank_size;
        unsigned int i, k;
 
@@ -666,7 +666,7 @@ static int tegra_pinctrl_resume(struct device *dev)
 {
        struct tegra_pmx *pmx = dev_get_drvdata(dev);
        u32 *backup_regs = pmx->backup_regs;
-       u32 *regs;
+       u32 __iomem *regs;
        size_t bank_size;
        unsigned int i, k;