fbdev: sh_mobile_lcdcfb: Fix ARGB32 overlay format typo
authorGeert Uytterhoeven <geert+renesas@glider.be>
Thu, 22 Jun 2023 09:28:48 +0000 (11:28 +0200)
committerHelge Deller <deller@gmx.de>
Thu, 22 Jun 2023 17:37:40 +0000 (19:37 +0200)
When configurating a CHn Source Image Format Register (LDBBSIFR), one
should use the corresponding LDBBSIFR_RPKF_* definition for overlay
planes, not the DDFR_PKF_* definition for the primary plane.

Fortunately both definitions resolve to the same value, so this bug did
not cause any harm.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/sh_mobile_lcdcfb.c

index 093f035..0adb2ba 100644 (file)
@@ -824,7 +824,7 @@ static void sh_mobile_lcdc_overlay_setup(struct sh_mobile_lcdc_overlay *ovl)
                format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDBBSIFR_RPKF_RGB24;
                break;
        case V4L2_PIX_FMT_BGR32:
-               format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDDFR_PKF_ARGB32;
+               format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDBBSIFR_RPKF_ARGB32;
                break;
        case V4L2_PIX_FMT_NV12:
        case V4L2_PIX_FMT_NV21: