media: i2c: rdacm20: Check return values
authorJacopo Mondi <jacopo+renesas@jmondi.org>
Wed, 16 Jun 2021 12:46:15 +0000 (14:46 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 17 Jun 2021 09:55:19 +0000 (11:55 +0200)
The camera module initialization routine does not check the return
value of a few functions. Fix that.

Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/rdacm20.c

index 343604b..0fc5512 100644 (file)
@@ -466,11 +466,16 @@ static int rdacm20_initialize(struct rdacm20_device *dev)
         *  Ensure that we have a good link configuration before attempting to
         *  identify the device.
         */
-       max9271_configure_i2c(&dev->serializer, MAX9271_I2CSLVSH_469NS_234NS |
-                                               MAX9271_I2CSLVTO_1024US |
-                                               MAX9271_I2CMSTBT_105KBPS);
+       ret = max9271_configure_i2c(&dev->serializer,
+                                   MAX9271_I2CSLVSH_469NS_234NS |
+                                   MAX9271_I2CSLVTO_1024US |
+                                   MAX9271_I2CMSTBT_105KBPS);
+       if (ret)
+               return ret;
 
-       max9271_configure_gmsl_link(&dev->serializer);
+       ret = max9271_configure_gmsl_link(&dev->serializer);
+       if (ret)
+               return ret;
 
        ret = max9271_verify_id(&dev->serializer);
        if (ret < 0)