crypto: ccp - Add a call to xts_check_key()
authorGary R Hook <gary.hook@amd.com>
Tue, 25 Jul 2017 19:21:23 +0000 (14:21 -0500)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 4 Aug 2017 01:27:42 +0000 (09:27 +0800)
Vet the key using the available standard function

Signed-off-by: Gary R Hook <gary.hook@amd.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/ccp/ccp-crypto-aes-xts.c

index 3f26a41..2b5d3a6 100644 (file)
@@ -16,6 +16,7 @@
 #include <linux/delay.h>
 #include <linux/scatterlist.h>
 #include <crypto/aes.h>
+#include <crypto/xts.h>
 #include <crypto/internal/skcipher.h>
 #include <crypto/scatterwalk.h>
 
@@ -97,7 +98,13 @@ static int ccp_aes_xts_complete(struct crypto_async_request *async_req, int ret)
 static int ccp_aes_xts_setkey(struct crypto_ablkcipher *tfm, const u8 *key,
                              unsigned int key_len)
 {
-       struct ccp_ctx *ctx = crypto_tfm_ctx(crypto_ablkcipher_tfm(tfm));
+       struct crypto_tfm *xfm = crypto_ablkcipher_tfm(tfm);
+       struct ccp_ctx *ctx = crypto_tfm_ctx(xfm);
+       int ret;
+
+       ret = xts_check_key(xfm, key, key_len);
+       if (ret)
+               return ret;
 
        /* Only support 128-bit AES key with a 128-bit Tweak key,
         * otherwise use the fallback