[media] media: davinci: vpbe: missing clk_put
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Thu, 6 Nov 2014 13:04:27 +0000 (10:04 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 11 Nov 2014 10:48:21 +0000 (08:48 -0200)
we are getting struct clk using clk_get before calling
clk_prepare_enable. but if clk_prepare_enable fails, then we are
jumping to fail_mutex_unlock where we are just unlocking the mutex,
but we are not freeing the clock source.
this patch just adds a call to clk_put before jumping to
fail_mutex_unlock.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/platform/davinci/vpbe.c

index 49d2de0..e5df991 100644 (file)
@@ -625,6 +625,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
                }
                if (clk_prepare_enable(vpbe_dev->dac_clk)) {
                        ret =  -ENODEV;
+                       clk_put(vpbe_dev->dac_clk);
                        goto fail_mutex_unlock;
                }
        }