OMAPDSS: HDMI: Convert to devm_request_and_ioremap
authorRicardo Neri <ricardo.neri@ti.com>
Tue, 6 Nov 2012 06:19:12 +0000 (00:19 -0600)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 6 Nov 2012 11:33:35 +0000 (13:33 +0200)
Using devm_request_and_ioremap provides better memory handling and
improves readability.

Signed-off-by: Ricardo Neri <ricardo.neri@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/omap2/dss/hdmi.c

index 72ab260..1d04bc0 100644 (file)
@@ -1064,7 +1064,7 @@ static int __init omapdss_hdmihw_probe(struct platform_device *pdev)
        }
 
        /* Base address taken from platform */
-       hdmi.ip_data.base_wp = ioremap(res->start, resource_size(res));
+       hdmi.ip_data.base_wp = devm_request_and_ioremap(&pdev->dev, res);
        if (!hdmi.ip_data.base_wp) {
                DSSERR("can't ioremap WP\n");
                return -ENOMEM;
@@ -1072,7 +1072,7 @@ static int __init omapdss_hdmihw_probe(struct platform_device *pdev)
 
        r = hdmi_get_clocks(pdev);
        if (r) {
-               iounmap(hdmi.ip_data.base_wp);
+               DSSERR("can't get clocks\n");
                return r;
        }
 
@@ -1117,8 +1117,6 @@ static int __exit omapdss_hdmihw_remove(struct platform_device *pdev)
 
        hdmi_put_clocks();
 
-       iounmap(hdmi.ip_data.base_wp);
-
        return 0;
 }