staging: rtl8188eu: remove goto label
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Thu, 16 Jul 2015 11:28:09 +0000 (16:58 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 Jul 2015 17:18:09 +0000 (10:18 -0700)
By checking for the success of kzalloc we were able to remove the goto
label thus making the code more readable.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/os_dep/usb_intf.c

index 21744a5..f68875b 100644 (file)
@@ -115,14 +115,11 @@ static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)
        mutex_init(&pdvobjpriv->usb_vendor_req_mutex);
        pdvobjpriv->usb_vendor_req_buf = kzalloc(MAX_USB_IO_CTL_SIZE, GFP_KERNEL);
 
-       if (!pdvobjpriv->usb_vendor_req_buf)
-               goto free_dvobj;
-
-       usb_get_dev(pusbd);
-
-       status = _SUCCESS;
+       if (pdvobjpriv->usb_vendor_req_buf) {
+               usb_get_dev(pusbd);
+               status = _SUCCESS;
+       }
 
-free_dvobj:
        if (status != _SUCCESS) {
                usb_set_intfdata(usb_intf, NULL);
                kfree(pdvobjpriv);