spi: tegra210-quad: Fix missin IRQ check in tegra_qspi_probe
authorMiaoqian Lin <linmq006@gmail.com>
Fri, 28 Jan 2022 16:59:56 +0000 (16:59 +0000)
committerMark Brown <broonie@kernel.org>
Tue, 8 Feb 2022 13:40:21 +0000 (13:40 +0000)
This func misses checking for platform_get_irq()'s call and may passes the
negative error codes to request_threaded_irq(), which takes unsigned IRQ #,
causing it to fail with -EINVAL, overriding an original error code.
Stop calling request_threaded_irq() with invalid IRQ #s.

Fixes: 921fc1838fb0 ("spi: tegra210-quad: Add support for Tegra210 QSPI controller")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220128165956.27821-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-tegra210-quad.c

index ce1bdb4..cb00ac2 100644 (file)
@@ -1240,6 +1240,8 @@ static int tegra_qspi_probe(struct platform_device *pdev)
 
        tqspi->phys = r->start;
        qspi_irq = platform_get_irq(pdev, 0);
+       if (qspi_irq < 0)
+               return qspi_irq;
        tqspi->irq = qspi_irq;
 
        tqspi->clk = devm_clk_get(&pdev->dev, "qspi");