devlink: use -ENOSPC to indicate no more room for snapshots
authorJacob Keller <jacob.e.keller@intel.com>
Thu, 26 Mar 2020 18:37:12 +0000 (11:37 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Mar 2020 02:39:26 +0000 (19:39 -0700)
The devlink_region_snapshot_create function returns -ENOMEM when the
maximum number of snapshots has been reached. This is confusing because
it is not an issue of being out of memory. Change this to use -ENOSPC
instead.

Reported-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/devlink.c

index 5d6887b..696660b 100644 (file)
@@ -3793,7 +3793,7 @@ __devlink_region_snapshot_create(struct devlink_region *region,
 
        /* check if region can hold one more snapshot */
        if (region->cur_snapshots == region->max_snapshots)
-               return -ENOMEM;
+               return -ENOSPC;
 
        if (devlink_region_snapshot_get_by_id(region, snapshot_id))
                return -EEXIST;