wifi: iwlwifi: remove dead code in iwl_dump_ini_imr_get_size()
authorMukesh Sisodiya <mukesh.sisodiya@intel.com>
Wed, 31 May 2023 16:50:04 +0000 (19:50 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 6 Jun 2023 11:40:21 +0000 (13:40 +0200)
Remove the check for the IMR debug data size which
leads to dead code.

Signed-off-by: Mukesh Sisodiya <mukesh.sisodiya@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230531194630.58eec8d40729.Ifb7d64706eed45726db804f36e785283dff7adab@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/fw/dbg.c

index d9faaae..3180cab 100644 (file)
@@ -2031,7 +2031,6 @@ static u32
 iwl_dump_ini_imr_get_size(struct iwl_fw_runtime *fwrt,
                          struct iwl_dump_ini_region_data *reg_data)
 {
-       u32 size = 0;
        u32 ranges = 0;
        u32 imr_enable = fwrt->trans->dbg.imr_data.imr_enable;
        u32 imr_size = fwrt->trans->dbg.imr_data.imr_size;
@@ -2041,17 +2040,16 @@ iwl_dump_ini_imr_get_size(struct iwl_fw_runtime *fwrt,
                IWL_DEBUG_INFO(fwrt,
                               "WRT: Invalid imr data enable: %d, imr_size: %d, sram_size: %d\n",
                               imr_enable, imr_size, sram_size);
-               return size;
+               return 0;
        }
-       size = imr_size;
        ranges = iwl_dump_ini_imr_ranges(fwrt, reg_data);
-       if (!size && !ranges) {
-               IWL_ERR(fwrt, "WRT: imr_size :=%d, ranges :=%d\n", size, ranges);
+       if (!ranges) {
+               IWL_ERR(fwrt, "WRT: ranges :=%d\n", ranges);
                return 0;
        }
-       size += sizeof(struct iwl_fw_ini_error_dump) +
+       imr_size += sizeof(struct iwl_fw_ini_error_dump) +
                ranges * sizeof(struct iwl_fw_ini_error_dump_range);
-       return size;
+       return imr_size;
 }
 
 /**