ACPI: video: Change GIGABYTE GB-BXBT-2807 quirk to force_none
authorHans de Goede <hdegoede@redhat.com>
Mon, 14 Nov 2022 14:44:54 +0000 (15:44 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:57 +0000 (13:32 +0100)
[ Upstream commit 9f7dd272ff9338f1f43c7a837d5a7ee67811d552 ]

The GIGABYTE GB-BXBT-2807 DMI quirk was added by
commit 25417185e9b5 ("ACPI: video: Add DMI quirk for GIGABYTE
GB-BXBT-2807") which says the following in its commit message:

"The GIGABYTE GB-BXBT-2807 is a mini-PC which uses off the shelf
components, like an Intel GPU which is meant for mobile systems.
As such, it, by default, has a backlight controller exposed.

Unfortunately, the backlight controller only confuses userspace, which
sees the existence of a backlight device node and has the unrealistic
belief that there is actually a backlight there!

Add a DMI quirk to force the backlight off on this system."

So in essence this quirk was using a video_detect_force_vendor quirk
to disable backlight control. Now a days we have a specific "none"
backlight type for this. Change the quirk to video_detect_force_none
and group it together with the other force_none quirks.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/acpi/video_detect.c

index b2a6162..375d1ef 100644 (file)
@@ -199,14 +199,6 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
        },
        {
         .callback = video_detect_force_vendor,
-        /* GIGABYTE GB-BXBT-2807 */
-        .matches = {
-               DMI_MATCH(DMI_SYS_VENDOR, "GIGABYTE"),
-               DMI_MATCH(DMI_PRODUCT_NAME, "GB-BXBT-2807"),
-               },
-       },
-       {
-        .callback = video_detect_force_vendor,
         /* Samsung N150/N210/N220 */
         .matches = {
                DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
@@ -673,6 +665,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
        },
        {
         .callback = video_detect_force_none,
+        /* GIGABYTE GB-BXBT-2807 */
+        .matches = {
+               DMI_MATCH(DMI_SYS_VENDOR, "GIGABYTE"),
+               DMI_MATCH(DMI_PRODUCT_NAME, "GB-BXBT-2807"),
+               },
+       },
+       {
+        .callback = video_detect_force_none,
         /* MSI MS-7721 */
         .matches = {
                DMI_MATCH(DMI_SYS_VENDOR, "MSI"),