cifs: Use kzfree() to zero out the password
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 27 Aug 2019 10:59:17 +0000 (13:59 +0300)
committerSteve French <stfrench@microsoft.com>
Tue, 27 Aug 2019 21:44:27 +0000 (16:44 -0500)
It's safer to zero out the password so that it can never be disclosed.

Fixes: 0c219f5799c7 ("cifs: set domainName when a domain-key is used in multiuser")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/connect.c

index 9d2576f..ddefdde 100644 (file)
@@ -3101,7 +3101,7 @@ cifs_set_cifscreds(struct smb_vol *vol, struct cifs_ses *ses)
                        rc = -ENOMEM;
                        kfree(vol->username);
                        vol->username = NULL;
-                       kfree(vol->password);
+                       kzfree(vol->password);
                        vol->password = NULL;
                        goto out_key_put;
                }