net: phy: marvell: Fix inconsistent indenting in led_blink_set
authorChristian Marangi <ansuelsmth@gmail.com>
Sun, 23 Apr 2023 17:28:00 +0000 (19:28 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 25 Apr 2023 02:01:47 +0000 (19:01 -0700)
Fix inconsistent indeinting in m88e1318_led_blink_set reported by kernel
test robot, probably done by the presence of an if condition dropped in
later revision of the same code.

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304240007.0VEX8QYG-lkp@intel.com/
Fixes: ea9e86485dec ("net: phy: marvell: Implement led_blink_set()")
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20230423172800.3470-1-ansuelsmth@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/marvell.c

index cd5d0ed..43b6cb7 100644 (file)
@@ -2880,10 +2880,10 @@ static int m88e1318_led_blink_set(struct phy_device *phydev, u8 index,
        case 1:
        case 2:
                reg &= ~(0xf << (4 * index));
-                       reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
-                       /* Reset default is 84ms */
-                       *delay_on = 84 / 2;
-                       *delay_off = 84 / 2;
+               reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
+               /* Reset default is 84ms */
+               *delay_on = 84 / 2;
+               *delay_off = 84 / 2;
                break;
        default:
                return -EINVAL;