client/advertising: Fixes errors found by scan-build

This fixes the following errors:

client/advertising.c:129:4: warning: Value stored to 'n' is never read
[deadcode.DeadStores]
                        n = sizeof(str) - 1;
                        ^   ~~~~~~~~~~~~~~~
client/advertising.c:1012:25: warning: Dereference of null pointer
(loaded from variable 'min') [core.NullDereference]
        if (ad.min_interval != *min) {
                               ^~~~

Signed-off-by: Manika Shrivastava <manika.sh@samsung.com>
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>

diff --git a/client/advertising.c b/client/advertising.c
index ef7aa2e..f637604 100644 (file)
--- a/client/advertising.c
+++ b/client/advertising.c
@@ -124,8 +124,6 @@ static void print_uuid(const char *uuid)
                        str[sizeof(str) - 3] = '.';
                        if (str[sizeof(str) - 4] == ' ')
                                str[sizeof(str) - 4] = '.';
-
-                       n = sizeof(str) - 1;
                }
 
                bt_shell_printf("UUID: %s(%s)\n", str, uuid);
@@ -1008,13 +1006,13 @@ void ad_advertise_interval(DBusConnection *conn, uint32_t *min, uint32_t *max)
                return bt_shell_noninteractive_quit(EXIT_SUCCESS);
        }
 
-       if (ad.min_interval != *min) {
+       if (min && ad.min_interval != *min) {
                ad.min_interval = *min;
                g_dbus_emit_property_changed(conn, AD_PATH, AD_IFACE,
                                                        "MinInterval");
        }
 
-       if (ad.max_interval != *max) {
+       if (max && ad.max_interval != *max) {
                ad.max_interval = *max;
                g_dbus_emit_property_changed(conn, AD_PATH, AD_IFACE,
                                                        "MaxInterval");