pan/bi: Simplfy BLEND emit
authorAlyssa Rosenzweig <alyssa@collabora.com>
Tue, 10 May 2022 16:23:28 +0000 (12:23 -0400)
committerMarge Bot <emma+marge@anholt.net>
Thu, 19 May 2022 16:08:26 +0000 (16:08 +0000)
We don't need to collect anything, now that Valhall handles this case correctly.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16585>

src/panfrost/bifrost/bifrost_compile.c

index 7806717..f4ac22d 100644 (file)
@@ -751,17 +751,13 @@ bi_emit_blend_op(bi_builder *b, bi_index rgba, nir_alu_type T,
         } else if (b->shader->inputs->is_blend) {
                 uint64_t blend_desc = b->shader->inputs->blend.bifrost_blend_desc;
 
-                bi_index desc =
-                        bi_collect_v2i32(b, bi_imm_u32(blend_desc),
-                                            bi_imm_u32(blend_desc >> 32));
-
                 /* Blend descriptor comes from the compile inputs */
                 /* Put the result in r0 */
 
                 bi_blend_to(b, bifrost ? bi_register(0) : bi_null(), rgba,
                                 bi_register(60),
-                                bi_word(desc, 0),
-                                bi_word(desc, 1),
+                                bi_imm_u32(blend_desc),
+                                bi_imm_u32(blend_desc >> 32),
                                 bi_null(), regfmt, sr_count, 0);
         } else {
                 /* Blend descriptor comes from the FAU RAM. By convention, the