usb: dwc2: gadget: Fix coverity issue
authorGrigor Tovmasyan <Grigor.Tovmasyan@synopsys.com>
Tue, 3 Apr 2018 11:22:25 +0000 (15:22 +0400)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Mon, 21 May 2018 07:40:16 +0000 (10:40 +0300)
When _param is unsigned and the minimum value of range is 0, it gives
the following warning:
COVERITY NO_EFFECT: This less-than-zero comparison of an unsigned value
is never true.

Converting ._param to int to avoid this warning.

Signed-off-by: Grigor Tovmasyan <tovmasya@synopsys.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/dwc2/params.c

index a24ba13..af075d4 100644 (file)
@@ -556,7 +556,7 @@ static void dwc2_check_param_tx_fifo_sizes(struct dwc2_hsotg *hsotg)
 }
 
 #define CHECK_RANGE(_param, _min, _max, _def) do {                     \
-               if ((hsotg->params._param) < (_min) ||                  \
+               if ((int)(hsotg->params._param) < (_min) ||             \
                    (hsotg->params._param) > (_max)) {                  \
                        dev_warn(hsotg->dev, "%s: Invalid parameter %s=%d\n", \
                                 __func__, #_param, hsotg->params._param); \