Add compiler warning flags and fix compile warning

[Problem]
In case of adding compiler warning, there is one build error in class NetherCynaraBackend

The order of member variable between cynaraConfig and cynaraResult in class declaration is different from order of enumeration in constructor

* class declaration
class NetherCynaraBackend : public NetherPolicyBackend
{
   ....
   private:
   ....

          cynara_async_configuration *cynaraConfig;
          std::vector<u_int32_t> responseQueue;
          int cynaraResult;
}

* constructor
NetherCynaraBackend::NetherCynaraBackend(const NetherConfig &netherConfig)
             : NetherPolicyBackend(netherConfig), currentCynaraDescriptor(0),
             cynaraLastResult(CYNARA_API_UNKNOWN_ERROR), CynaraConfig(nullptr)

[Fix]
Change order between cynaraResult and cynaraConfig of class declaration

Change-Id: Ia03b10a33ee6b025ee28d76b82035e8f9cfb68d1
Signed-off-by: seong.chung <seong.chung@samsung.com>

diff --git a/CMakeLists.txt b/CMakeLists.txt
index ff080b652bc48dabedc949421515c8f870e5d92d..dff3af08709ea6e03e9198c3016d3b3881fbb0f4 100644 (file)
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -19,6 +19,12 @@
 CMAKE_MINIMUM_REQUIRED (VERSION 2.6)
 PROJECT (nether)
 INCLUDE (FindPkgConfig)
+
+# Set compiler warning flags
+ADD_DEFINITIONS("-Werror")                      # Make all warnings into errors.
+ADD_DEFINITIONS("-Wall")                        # Generate all warnings
+ADD_DEFINITIONS("-Wextra")                      # Generate even more extra warnings
+
 IF (CMAKE_BUILD_TYPE MATCHES DEBUG)
        SET (CMAKE_CXX_FLAGS "-g -Wall -Wextra -std=c++11")
 ELSE ()
@@ -35,5 +41,6 @@ IF (NOT DEFINED SYSTEMD_UNIT_DIR)
        SET(SYSTEMD_UNIT_DIR "${CMAKE_INSTALL_PREFIX}/lib/systemd/system")
 ENDIF (NOT DEFINED SYSTEMD_UNIT_DIR)
 
+
 ADD_SUBDIRECTORY (src)
 ADD_SUBDIRECTORY (conf)

diff --git a/include/nether_CynaraBackend.h b/include/nether_CynaraBackend.h
index 4dd52b1a6505260333073353443cbe068679b0e2..d0ba8c0e0540f9d9a103168f78950b8b620fd11b 100644 (file)
--- a/include/nether_CynaraBackend.h
+++ b/include/nether_CynaraBackend.h
@@ -58,9 +58,9 @@ class NetherCynaraBackend : public NetherPolicyBackend
                cynara_async *cynaraContext;
                NetherDescriptorStatus currentCynaraDescriptorStatus;
                int currentCynaraDescriptor;
+               int cynaraLastResult;
                cynara_async_configuration *cynaraConfig;
                std::vector<u_int32_t> responseQueue;
-               int cynaraLastResult;
 };
 
 #endif // HAVE_CYNARA