efi_loader: don't set EFI_RT_SUPPORTED_UPDATE_CAPSULE
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Wed, 9 Dec 2020 06:38:46 +0000 (07:38 +0100)
committerHeinrich Schuchardt <xypron.glpk@gmx.de>
Thu, 10 Dec 2020 08:15:32 +0000 (09:15 +0100)
The EFI_RT_PROPERTIES_TABLE configuration table indicates which runtime
services are available at runtime.

Even if CONFIG_EFI_RUNTIME_UPDATE_CAPSULE=y, we neither support
UpdateCapsule() nor QueryCapsuleCapabilities() at runtime. Thus we should
not set the corresponding flags EFI_RT_SUPPORTED_UPDATE_CAPSULE and
EFI_RT_SUPPORTED_QUERY_CAPSULE_CAPABILITIES in RuntimeServicesSupported.

Fixes: 2bc27ca8a04a ("efi_loader: define UpdateCapsule api")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
lib/efi_loader/efi_runtime.c

index 0b171c1..93c9478 100644 (file)
@@ -133,10 +133,6 @@ efi_status_t efi_init_runtime_supported(void)
 #ifdef CONFIG_EFI_HAVE_RUNTIME_RESET
        rt_table->runtime_services_supported |= EFI_RT_SUPPORTED_RESET_SYSTEM;
 #endif
-       if (IS_ENABLED(CONFIG_EFI_RUNTIME_UPDATE_CAPSULE))
-               rt_table->runtime_services_supported |=
-                       (EFI_RT_SUPPORTED_UPDATE_CAPSULE |
-                        EFI_RT_SUPPORTED_QUERY_CAPSULE_CAPABILITIES);
 
        ret = efi_install_configuration_table(&efi_rt_properties_table_guid,
                                              rt_table);