drm/tegra: Don't call SET_APPLICATION_ID in VIC boot

The application should be programming the application ID, not
the kernel, as there can be several options to choose from,
and setting the application ID multiple times can cause issues.

Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>

diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c
index 72aea1c..c9d55a9 100644 (file)
--- a/drivers/gpu/drm/tegra/vic.c
+++ b/drivers/gpu/drm/tegra/vic.c
@@ -148,8 +148,6 @@ static int vic_boot(struct vic *vic)
        hdr = vic->falcon.firmware.virt;
        fce_bin_data_offset = *(u32 *)(hdr + VIC_UCODE_FCE_DATA_OFFSET);
 
-       falcon_execute_method(&vic->falcon, VIC_SET_APPLICATION_ID, 1);
-
        /* Old VIC firmware needs kernel help with setting up FCE microcode. */
        if (fce_bin_data_offset != 0x0 && fce_bin_data_offset != 0xa5a5a5a5) {
                hdr = vic->falcon.firmware.virt +

diff --git a/drivers/gpu/drm/tegra/vic.h b/drivers/gpu/drm/tegra/vic.h
index be898be..acf35aa 100644 (file)
--- a/drivers/gpu/drm/tegra/vic.h
+++ b/drivers/gpu/drm/tegra/vic.h
@@ -8,7 +8,6 @@
 
 /* VIC methods */
 
-#define VIC_SET_APPLICATION_ID                 0x00000200
 #define VIC_SET_FCE_UCODE_SIZE                 0x0000071C
 #define VIC_SET_FCE_UCODE_OFFSET               0x0000072C