pinctrl: armada-37xx: Reuse GPIO fwnode in armada_37xx_irqchip_register()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 1 Apr 2022 10:36:04 +0000 (13:36 +0300)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 18 Apr 2022 13:18:48 +0000 (16:18 +0300)
Since we have fwnode of the first found GPIO controller assigned to the
struct gpio_chip, we may reuse it in the armada_37xx_irqchip_register().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c

index 110f70b..ef4118e 100644 (file)
@@ -727,23 +727,13 @@ static int armada_37xx_irqchip_register(struct platform_device *pdev,
        struct gpio_chip *gc = &info->gpio_chip;
        struct irq_chip *irqchip = &info->irq_chip;
        struct gpio_irq_chip *girq = &gc->irq;
+       struct device_node *np = to_of_node(gc->fwnode);
        struct device *dev = &pdev->dev;
-       struct device_node *np;
-       int ret = -ENODEV, i, nr_irq_parent;
-
-       /* Check if we have at least one gpio-controller child node */
-       for_each_child_of_node(dev->of_node, np) {
-               if (of_property_read_bool(np, "gpio-controller")) {
-                       ret = 0;
-                       break;
-               }
-       }
-       if (ret)
-               return dev_err_probe(dev, ret, "no gpio-controller child node\n");
+       unsigned int i, nr_irq_parent;
 
-       nr_irq_parent = of_irq_count(np);
        spin_lock_init(&info->irq_lock);
 
+       nr_irq_parent = of_irq_count(np);
        if (!nr_irq_parent) {
                dev_err(dev, "invalid or no IRQ\n");
                return 0;