[Title] JSDT : finallyMustCompleteNormally warning is fixed by new policy

[Desc.] finallyMustCompleteNormally warning is blocked and removed
from validator preference.
[Issue] REDMINE-6836

diff --git a/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/internal/compiler/problem/ProblemReporter.java b/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/internal/compiler/problem/ProblemReporter.java
index 1de48d9..df83d95 100644 (file)
--- a/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/internal/compiler/problem/ProblemReporter.java
+++ b/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/internal/compiler/problem/ProblemReporter.java
@@ -839,12 +839,13 @@ public void fieldHiding(FieldDeclaration fieldDecl, Binding hiddenVariable) {
        }
 }
 public void finallyMustCompleteNormally(Block finallyBlock) {
-       this.handle(
-               IProblem.FinallyMustCompleteNormally,
-               NoArgument,
-               NoArgument,
-               finallyBlock.sourceStart,
-               finallyBlock.sourceEnd);
+// Comment by new policy
+//     this.handle(
+//             IProblem.FinallyMustCompleteNormally,
+//             NoArgument,
+//             NoArgument,
+//             finallyBlock.sourceStart,
+//             finallyBlock.sourceEnd);
 }
 public void forbiddenReference(FieldBinding field, ASTNode location,
                String messageTemplate, int problemId) {

diff --git a/org.eclipse.wst.jsdt.ui/src/org/eclipse/wst/jsdt/internal/ui/preferences/ProblemSeveritiesConfigurationBlock.java b/org.eclipse.wst.jsdt.ui/src/org/eclipse/wst/jsdt/internal/ui/preferences/ProblemSeveritiesConfigurationBlock.java
index ac5dce1..8e6d66b 100644 (file)
--- a/org.eclipse.wst.jsdt.ui/src/org/eclipse/wst/jsdt/internal/ui/preferences/ProblemSeveritiesConfigurationBlock.java
+++ b/org.eclipse.wst.jsdt.ui/src/org/eclipse/wst/jsdt/internal/ui/preferences/ProblemSeveritiesConfigurationBlock.java
@@ -313,8 +313,8 @@ public class ProblemSeveritiesConfigurationBlock extends OptionsConfigurationBlo
 //             label= PreferencesMessages.ProblemSeveritiesConfigurationBlock_pb_accidential_assignement_label; 
 //             addComboBox(inner, label, PREF_PB_POSSIBLE_ACCIDENTAL_BOOLEAN_ASSIGNMENT, errorWarningIgnore, errorWarningIgnoreLabels, defaultIndent);
 
-               label= PreferencesMessages.ProblemSeveritiesConfigurationBlock_pb_finally_block_not_completing_label; 
-               addComboBox(inner, label, PREF_PB_FINALLY_BLOCK_NOT_COMPLETING, errorWarningIgnore, errorWarningIgnoreLabels, defaultIndent);
+//             label= PreferencesMessages.ProblemSeveritiesConfigurationBlock_pb_finally_block_not_completing_label; 
+//             addComboBox(inner, label, PREF_PB_FINALLY_BLOCK_NOT_COMPLETING, errorWarningIgnore, errorWarningIgnoreLabels, defaultIndent);
 
                label= PreferencesMessages.ProblemSeveritiesConfigurationBlock_pb_empty_statement_label; 
                addComboBox(inner, label, PREF_PB_EMPTY_STATEMENT, errorWarningIgnore, errorWarningIgnoreLabels, defaultIndent);