Fix static analysis issues

Changes:
 - Adds explicit type casting.

Change-Id: I3fe1030167582498b80313af7df1bdcdfc8a5780
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>

diff --git a/parser/exec-checker/src/exec_checker.cc b/parser/exec-checker/src/exec_checker.cc
index 7f44813..7bb3de2 100644 (file)
--- a/parser/exec-checker/src/exec_checker.cc
+++ b/parser/exec-checker/src/exec_checker.cc
@@ -56,7 +56,7 @@ Shdr* GetSectionFromShdr(const char* name, Shdr* shdr,
 }
 
 int Read(FILE* fp, void* ptr, long offset, size_t size) {
-  if (offset < 0 || size <= 0) {
+  if (offset < 0 || size == 0) {
     LOGE_STD("Invalid parameter");
     return -1;
   }
@@ -75,8 +75,8 @@ int Read(FILE* fp, void* ptr, long offset, size_t size) {
   return 0;
 }
 
-char* GetDataFromFile(FILE* fp, long offset, size_t size) {
-  if (offset < 0 || size <= 0) {
+char* GetDataFromFile(FILE* fp, unsigned long offset, size_t size) {
+  if (size == 0) {
     LOGE_STD("Invalid parameter");
     return nullptr;
   }
@@ -87,7 +87,7 @@ char* GetDataFromFile(FILE* fp, long offset, size_t size) {
     return nullptr;
   }
 
-  if (Read(fp, ptr, offset, size) < 0) {
+  if (Read(fp, ptr, static_cast<long>(offset & __LONG_MAX__), size) < 0) {
     free(ptr);
     return nullptr;
   }