platform/x86: ideapad-laptop: hide unused 'touchpad_store'
authorArnd Bergmann <arnd@arndb.de>
Mon, 22 May 2017 13:07:03 +0000 (15:07 +0200)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 23 May 2017 16:36:25 +0000 (19:36 +0300)
A readonly sysfs property must not have a 'store' function:

drivers/platform/x86/ideapad-laptop.c:438:16: error: 'touchpad_store' defined but not used [-Werror=unused-function]

We can either comment it out or remove the function entirely,
without a good reason one or or another I picked the second option.

Fixes: 7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/ideapad-laptop.c

index f7a4608..e4c83c1 100644 (file)
@@ -435,9 +435,10 @@ static ssize_t touchpad_show(struct device *dev,
        return sprintf(buf, "%lu\n", result);
 }
 
-static ssize_t touchpad_store(struct device *dev,
-                             struct device_attribute *attr,
-                             const char *buf, size_t count)
+/* Switch to RO for now: It might be revisited in the future */
+static ssize_t __maybe_unused touchpad_store(struct device *dev,
+                                            struct device_attribute *attr,
+                                            const char *buf, size_t count)
 {
        struct ideapad_private *priv = dev_get_drvdata(dev);
        bool state;
@@ -453,7 +454,6 @@ static ssize_t touchpad_store(struct device *dev,
        return count;
 }
 
-/* Switch to RO for now: It might be revisited in the future */
 static DEVICE_ATTR_RO(touchpad);
 
 static struct attribute *ideapad_attributes[] = {