git-update: Make fetching of external repos non-fatal on the CI

Fixes intermittent failures when external repos have downtime. This is
common with GNOME Gitlab. Only error out on CI if a FDO gitlab repo
fails to fetch.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-build/-/merge_requests/240>

diff --git a/git-update b/git-update
index 03ce87f7a0962db02ff31e7e3bd570ca0d128d71..f295db0dbdbd1a6f80a51526666b5fb98a8dcb66 100755 (executable)
--- a/git-update
+++ b/git-update
@@ -14,6 +14,7 @@ from scripts.common import get_meson
 SCRIPTDIR = os.path.normpath(os.path.dirname(__file__))
 # Force a checkout to happen and throw away local changes
 FORCE_CHECKOUT = False
+CI = os.environ.get('CI', False)
 
 
 def manifest_get_commits(manifest):
@@ -83,21 +84,35 @@ def check_repo_status(repo_name, worktree_dir):
                                     branch_message[0].strip(), repo_status(commit_message)))
     return True
 
+def fatal_git_fetches(repo_dir):
+    '''
+    When running on the CI, we usually have a cache, in which case we don't
+    want the git update to be fatal since we don't want our CI to fail when
+    there's downtime on external repos.
+    '''
+    if not CI:
+        return True
+    remote = git("remote", "get-url", "origin", repository_path=repo_dir)
+    if 'gitlab.freedesktop.org' in remote:
+        return True
+    return False
+
 def update_repo(repo_name, repo_dir, revision, no_interaction, fetch_args=[], recurse_i=0, status=False):
     if status:
       return check_repo_status(repo_name, repo_dir)
     revision = ensure_revision_if_necessary(repo_dir, revision)
     git("config", "rebase.autoStash", "true", repository_path=repo_dir)
+    fatal = fatal_git_fetches(repo_dir)
     try:
         if revision:
             print("Checking out %s in %s" % (revision, repo_name))
-            git("fetch", *fetch_args, repository_path=repo_dir)
+            git("fetch", *fetch_args, repository_path=repo_dir, fatal=fatal)
             checkout_args = ["--force"] if FORCE_CHECKOUT else []
             checkout_args += ["--detach", revision]
             git("checkout", *checkout_args, repository_path=repo_dir)
         else:
             print("Updating branch %s in %s" % (get_branch_name(repo_dir), repo_name))
-            git("pull", "--rebase", repository_path=repo_dir)
+            git("pull", "--rebase", repository_path=repo_dir, fatal=fatal)
         git("submodule", "update", repository_path=repo_dir)
     except Exception as e:
         out = getattr(e, "output", b"").decode()

diff --git a/scripts/common.py b/scripts/common.py
index f9c19850d252d1c56f69c0ac44f5fe345ae962d0..ec0cc707dba068fe73e1d2b047f3cdc423d98589 100644 (file)
--- a/scripts/common.py
+++ b/scripts/common.py
@@ -113,10 +113,17 @@ class Colors:
 
 
 
-def git(*args, repository_path='.'):
-    return subprocess.check_output(["git"] + list(args), cwd=repository_path,
-                                   stdin=subprocess.DEVNULL,
-                                   stderr=subprocess.STDOUT).decode()
+def git(*args, repository_path='.', fatal=True):
+    try:
+        ret = subprocess.check_output(["git"] + list(args), cwd=repository_path,
+                                      stdin=subprocess.DEVNULL,
+                                      stderr=subprocess.STDOUT).decode()
+    except subprocess.CalledProcessError as e:
+        if fatal:
+            raise e
+        print("Non-fatal error running git {}:\n{}".format(' '.join(args), e))
+        return None
+    return ret
 
 def accept_command(commands):
     """Search @commands and returns the first found absolute path."""