interconnect: icc-rpmh: Ignore return value of icc_provider_del() in .remove()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 18 Jul 2022 12:14:04 +0000 (14:14 +0200)
committerGeorgi Djakov <djakov@kernel.org>
Tue, 16 Aug 2022 13:38:04 +0000 (16:38 +0300)
icc_provider_del() already emits an error message on failure. In this
case letting .remove() return the corresponding error code results in
another error message and the device is removed anyhow. (See
platform_remove().)

So ignore the return value of icc_provider_del() and return 0
unconditionally.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220718121409.171773-4-u.kleine-koenig@pengutronix.de
Signed-off-by: Georgi Djakov <djakov@kernel.org>
drivers/interconnect/qcom/icc-rpmh.c

index 114bb8f..fd17291 100644 (file)
@@ -251,7 +251,9 @@ int qcom_icc_rpmh_remove(struct platform_device *pdev)
        struct qcom_icc_provider *qp = platform_get_drvdata(pdev);
 
        icc_nodes_remove(&qp->provider);
-       return icc_provider_del(&qp->provider);
+       icc_provider_del(&qp->provider);
+
+       return 0;
 }
 EXPORT_SYMBOL_GPL(qcom_icc_rpmh_remove);