[mlir][spirv] Float atomics should not imply Shader
authorButygin <ivan.butygin@intel.com>
Thu, 28 Oct 2021 16:04:35 +0000 (19:04 +0300)
committerButygin <ivan.butygin@intel.com>
Thu, 25 Nov 2021 09:07:28 +0000 (12:07 +0300)
Differential Revision: https://reviews.llvm.org/D114551

mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td

index 5429cf8c793206cb4eaf6355318b08e71f71d2ec..b3ca8c74b56bf71c0f50d453261333c2f58cc13e 100644 (file)
@@ -1210,19 +1210,22 @@ def SPV_C_IntegerFunctions2INTEL                      : I32EnumAttrCase<"Integer
   ];
 }
 def SPV_C_AtomicFloat32AddEXT                         : I32EnumAttrCase<"AtomicFloat32AddEXT", 6033> {
-  list<I32EnumAttrCase> implies = [SPV_C_Shader];
+  // Float atomics also supported in kernels (https://github.com/KhronosGroup/SPIRV-Headers/pull/257).
+  // list<I32EnumAttrCase> implies = [SPV_C_Shader];
   list<Availability> availability = [
     Extension<[SPV_EXT_shader_atomic_float_add]>
   ];
 }
 def SPV_C_AtomicFloat64AddEXT                         : I32EnumAttrCase<"AtomicFloat64AddEXT", 6034> {
-  list<I32EnumAttrCase> implies = [SPV_C_Shader];
+  // Float atomics also supported in kernels (https://github.com/KhronosGroup/SPIRV-Headers/pull/257).
+  // list<I32EnumAttrCase> implies = [SPV_C_Shader];
   list<Availability> availability = [
     Extension<[SPV_EXT_shader_atomic_float_add]>
   ];
 }
 def SPV_C_AtomicFloat16AddEXT                         : I32EnumAttrCase<"AtomicFloat16AddEXT", 6095> {
-  list<I32EnumAttrCase> implies = [SPV_C_Shader];
+  // Float atomics also supported in kernels (https://github.com/KhronosGroup/SPIRV-Headers/pull/257).
+  // list<I32EnumAttrCase> implies = [SPV_C_Shader];
   list<Availability> availability = [
     Extension<[SPV_EXT_shader_atomic_float16_add]>
   ];