fcoe: Add missing newlines in debug messages
authorBart Van Assche <bvanassche@acm.org>
Wed, 14 Aug 2013 15:42:09 +0000 (15:42 +0000)
committerRobert Love <robert.w.love@intel.com>
Wed, 4 Sep 2013 21:07:13 +0000 (14:07 -0700)
FCoE debug statements must end in a newline. Add one where it is missing.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Cc: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
drivers/scsi/fcoe/fcoe.c
drivers/scsi/fcoe/fcoe_sysfs.c

index 134ca3b..dff40b2 100644 (file)
@@ -1440,14 +1440,14 @@ static int fcoe_rcv(struct sk_buff *skb, struct net_device *netdev,
        ctlr = fcoe_to_ctlr(fcoe);
        lport = ctlr->lp;
        if (unlikely(!lport)) {
-               FCOE_NETDEV_DBG(netdev, "Cannot find hba structure");
+               FCOE_NETDEV_DBG(netdev, "Cannot find hba structure\n");
                goto err2;
        }
        if (!lport->link_up)
                goto err2;
 
-       FCOE_NETDEV_DBG(netdev, "skb_info: len:%d data_len:%d head:%p "
-                       "data:%p tail:%p end:%p sum:%d dev:%s",
+       FCOE_NETDEV_DBG(netdev,
+                       "skb_info: len:%d data_len:%d head:%p data:%p tail:%p end:%p sum:%d dev:%s\n",
                        skb->len, skb->data_len, skb->head, skb->data,
                        skb_tail_pointer(skb), skb_end_pointer(skb),
                        skb->csum, skb->dev ? skb->dev->name : "<NULL>");
@@ -1794,13 +1794,13 @@ static void fcoe_recv_frame(struct sk_buff *skb)
        lport = fr->fr_dev;
        if (unlikely(!lport)) {
                if (skb->destructor != fcoe_percpu_flush_done)
-                       FCOE_NETDEV_DBG(skb->dev, "NULL lport in skb");
+                       FCOE_NETDEV_DBG(skb->dev, "NULL lport in skb\n");
                kfree_skb(skb);
                return;
        }
 
-       FCOE_NETDEV_DBG(skb->dev, "skb_info: len:%d data_len:%d "
-                       "head:%p data:%p tail:%p end:%p sum:%d dev:%s",
+       FCOE_NETDEV_DBG(skb->dev,
+                       "skb_info: len:%d data_len:%d head:%p data:%p tail:%p end:%p sum:%d dev:%s\n",
                        skb->len, skb->data_len,
                        skb->head, skb->data, skb_tail_pointer(skb),
                        skb_end_pointer(skb), skb->csum,
index c9382d6..922c9de 100644 (file)
@@ -300,29 +300,29 @@ static ssize_t store_ctlr_mode(struct device *dev,
 
        switch (ctlr->enabled) {
        case FCOE_CTLR_ENABLED:
-               LIBFCOE_SYSFS_DBG(ctlr, "Cannot change mode when enabled.");
+               LIBFCOE_SYSFS_DBG(ctlr, "Cannot change mode when enabled.\n");
                return -EBUSY;
        case FCOE_CTLR_DISABLED:
                if (!ctlr->f->set_fcoe_ctlr_mode) {
                        LIBFCOE_SYSFS_DBG(ctlr,
-                                         "Mode change not supported by LLD.");
+                                         "Mode change not supported by LLD.\n");
                        return -ENOTSUPP;
                }
 
                ctlr->mode = fcoe_parse_mode(mode);
                if (ctlr->mode == FIP_CONN_TYPE_UNKNOWN) {
-                       LIBFCOE_SYSFS_DBG(ctlr,
-                                         "Unknown mode %s provided.", buf);
+                       LIBFCOE_SYSFS_DBG(ctlr, "Unknown mode %s provided.\n",
+                                         buf);
                        return -EINVAL;
                }
 
                ctlr->f->set_fcoe_ctlr_mode(ctlr);
-               LIBFCOE_SYSFS_DBG(ctlr, "Mode changed to %s.", buf);
+               LIBFCOE_SYSFS_DBG(ctlr, "Mode changed to %s.\n", buf);
 
                return count;
        case FCOE_CTLR_UNUSED:
        default:
-               LIBFCOE_SYSFS_DBG(ctlr, "Mode change not supported.");
+               LIBFCOE_SYSFS_DBG(ctlr, "Mode change not supported.\n");
                return -ENOTSUPP;
        };
 }