io_uring: split slow path from io_queue_sqe
authorPavel Begunkov <asml.silence@gmail.com>
Fri, 24 Sep 2021 20:59:58 +0000 (21:59 +0100)
committerJens Axboe <axboe@kernel.dk>
Tue, 19 Oct 2021 11:49:53 +0000 (05:49 -0600)
We don't want the slow path of io_queue_sqe to be inlined, so extract a
function from it.

   text    data     bss     dec     hex filename
  91950   13986       8  105944   19dd8 ./fs/io_uring.o
  91758   13986       8  105752   19d18 ./fs/io_uring.o

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/fb01253911f8fb374268f65b1ba939b54ca6583f.1632516769.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index f0fb458..e5a414c 100644 (file)
@@ -6935,12 +6935,10 @@ issue_sqe:
        }
 }
 
-static inline void io_queue_sqe(struct io_kiocb *req)
+static void io_queue_sqe_fallback(struct io_kiocb *req)
        __must_hold(&req->ctx->uring_lock)
 {
-       if (likely(!(req->flags & (REQ_F_FORCE_ASYNC | REQ_F_FAIL)))) {
-               __io_queue_sqe(req);
-       } else if (req->flags & REQ_F_FAIL) {
+       if (req->flags & REQ_F_FAIL) {
                io_req_complete_fail_submit(req);
        } else if (unlikely(req->ctx->drain_active) && io_drain_req(req)) {
                return;
@@ -6954,6 +6952,15 @@ static inline void io_queue_sqe(struct io_kiocb *req)
        }
 }
 
+static inline void io_queue_sqe(struct io_kiocb *req)
+       __must_hold(&req->ctx->uring_lock)
+{
+       if (likely(!(req->flags & (REQ_F_FORCE_ASYNC | REQ_F_FAIL))))
+               __io_queue_sqe(req);
+       else
+               io_queue_sqe_fallback(req);
+}
+
 /*
  * Check SQE restrictions (opcode and flags).
  *