power: supply: cros_usbpd: Remove dev_err() getting the number of ports
authorEnric Balletbo i Serra <enric.balletbo@collabora.com>
Fri, 29 Nov 2019 21:59:16 +0000 (22:59 +0100)
committerSebastian Reichel <sre@kernel.org>
Thu, 19 Dec 2019 00:58:44 +0000 (01:58 +0100)
When a device has no support to get the charger number of ports, it
doesn't have to result in a dev_err(), print saying "Could not get
charger port count" using a dev_info() would suffice. In such case,
the dev_info() message is already printed but the dev_err() is annoying,
specially, on those devices that doesn't support the command. So remove
the dev_err().

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/cros_usbpd-charger.c

index 6cc7c39..ffad9ee 100644 (file)
@@ -132,11 +132,8 @@ static int cros_usbpd_charger_get_num_ports(struct charger_data *charger)
        ret = cros_usbpd_charger_ec_command(charger, 0,
                                            EC_CMD_CHARGE_PORT_COUNT,
                                            NULL, 0, &resp, sizeof(resp));
-       if (ret < 0) {
-               dev_err(charger->dev,
-                       "Unable to get the number of ports (err:0x%x)\n", ret);
+       if (ret < 0)
                return ret;
-       }
 
        return resp.port_count;
 }
@@ -148,11 +145,8 @@ static int cros_usbpd_charger_get_usbpd_num_ports(struct charger_data *charger)
 
        ret = cros_usbpd_charger_ec_command(charger, 0, EC_CMD_USB_PD_PORTS,
                                            NULL, 0, &resp, sizeof(resp));
-       if (ret < 0) {
-               dev_err(charger->dev,
-                       "Unable to get the number or ports (err:0x%x)\n", ret);
+       if (ret < 0)
                return ret;
-       }
 
        return resp.num_ports;
 }