net: phy: mediatek: fix compile-test dependencies
authorArnd Bergmann <arnd@arndb.de>
Fri, 16 Jun 2023 09:29:54 +0000 (11:29 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 20 Jun 2023 19:02:22 +0000 (12:02 -0700)
The new phy driver attempts to select a driver from another subsystem,
but that fails when the NVMEM subsystem is disabled:

WARNING: unmet direct dependencies detected for NVMEM_MTK_EFUSE
  Depends on [n]: NVMEM [=n] && (ARCH_MEDIATEK [=n] || COMPILE_TEST [=y]) && HAS_IOMEM [=y]
  Selected by [y]:
  - MEDIATEK_GE_SOC_PHY [=y] && NETDEVICES [=y] && PHYLIB [=y] && (ARM64 && ARCH_MEDIATEK [=n] || COMPILE_TEST [=y])

I could not see an actual compile time dependency, so presumably this
is only needed for for working correctly but not technically a dependency
on that particular nvmem driver implementation, so it would likely
be safe to remove the select for compile testing.

To keep the spirit of the original 'select', just replace this with a
'depends on' that ensures that the driver will work but does not get in
the way of build testing.

Fixes: 98c485eaf509b ("net: phy: add driver for MediaTek SoC built-in GE PHYs")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
Link: https://lore.kernel.org/r/20230616093009.3511692-1-arnd@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/Kconfig

index a40269c175974a72b474059223e2c8e602a5d884..78e6981650d9448e54be54f3dd7ecef59fbab2d7 100644 (file)
@@ -239,7 +239,7 @@ config MEDIATEK_GE_PHY
 config MEDIATEK_GE_SOC_PHY
        tristate "MediaTek SoC Ethernet PHYs"
        depends on (ARM64 && ARCH_MEDIATEK) || COMPILE_TEST
-       select NVMEM_MTK_EFUSE
+       depends on NVMEM_MTK_EFUSE
        help
          Supports MediaTek SoC built-in Gigabit Ethernet PHYs.