d3d12: fallback to integrated adapter instead of arbitrary one
authorTiago Koji Castro Shibata <tiago.shibata@gmail.com>
Thu, 26 May 2022 04:41:27 +0000 (21:41 -0700)
committerMarge Bot <emma+marge@anholt.net>
Thu, 16 Jun 2022 00:19:54 +0000 (00:19 +0000)
Using the integrated adapter when none is specified uses less power by
default and doesn't break scenarios on Optimus systems (for example, on
Surface Books, detaching the screen gets prohibited because the GPU on
the performance base is in use)

Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17005>

src/gallium/drivers/d3d12/d3d12_dxcore_screen.cpp

index b12f2f4..7017cbf 100644 (file)
@@ -110,7 +110,17 @@ choose_dxcore_adapter(IDXCoreAdapterFactory *factory, LUID *adapter_luid)
       }
 #endif
 
-      // No adapter specified or not found, pick 0 as the default
+      // Adapter not specified or not found, so pick an integrated adapter if possible
+      for (unsigned i = 0; i < list->GetAdapterCount(); ++i) {
+         if (SUCCEEDED(list->GetAdapter(i, &adapter))) {
+            bool is_integrated;
+            if (SUCCEEDED(adapter->GetProperty(DXCoreAdapterProperty::IsIntegrated, &is_integrated)) && is_integrated)
+               return adapter;
+            adapter->Release();
+         }
+      }
+
+      // No integrated GPUs, so pick the first valid one
       if (list->GetAdapterCount() > 0 && SUCCEEDED(list->GetAdapter(0, &adapter)))
          return adapter;
    }