Revert "mtd: spi-nor: macronix: Add support for mx25l51245g"
authorTudor Ambarus <tudor.ambarus@microchip.com>
Fri, 2 Apr 2021 08:20:30 +0000 (11:20 +0300)
committerTudor Ambarus <tudor.ambarus@microchip.com>
Sun, 11 Apr 2021 07:36:35 +0000 (10:36 +0300)
This reverts commit 04b8edad262eec0d153005973dfbdd83423c0dcb.

mx25l51245g and mx66l51235l have the same flash ID. The flash
detection returns the first entry in the flash_info array that
matches the flash ID that was read, thus for the 0xc2201a ID,
mx25l51245g was always hit, introducing a regression for
mx66l51235l.

If one wants to differentiate the flash names, a better fix would be
to differentiate between the two at run-time, depending on SFDP,
and choose the correct name from a list of flash names, depending on
the SFDP differentiator.

Fixes: 04b8edad262e ("mtd: spi-nor: macronix: Add support for mx25l51245g")
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Acked-by: Pratyush Yadav <p.yadav@ti.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20210402082031.19055-2-tudor.ambarus@microchip.com
drivers/mtd/spi-nor/macronix.c

index 6c2680b..42c2cf3 100644 (file)
@@ -72,9 +72,6 @@ static const struct flash_info macronix_parts[] = {
                              SECT_4K | SPI_NOR_DUAL_READ |
                              SPI_NOR_QUAD_READ) },
        { "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) },
-       { "mx25l51245g", INFO(0xc2201a, 0, 64 * 1024, 1024,
-                             SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
-                             SPI_NOR_4B_OPCODES) },
        { "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024,
                              SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
                              SPI_NOR_4B_OPCODES) },