net: qualcomm: rmnet: mark trailer field endianness
authorAlex Elder <elder@linaro.org>
Mon, 15 Mar 2021 21:51:46 +0000 (16:51 -0500)
committerDavid S. Miller <davem@davemloft.net>
Tue, 16 Mar 2021 03:41:58 +0000 (20:41 -0700)
The fields in the checksum trailer structure used for QMAP protocol
RX packets are all big-endian format, so define them that way.

It turns out these fields are never actually used by the RMNet code.
The start offset is always assumed to be zero, and the length is
taken from the other packet headers.  So making these fields
explicitly big endian has no effect on the behavior of the code.

Signed-off-by: Alex Elder <elder@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/if_rmnet.h

index 9661416..8c7845b 100644 (file)
@@ -32,8 +32,8 @@ struct rmnet_map_dl_csum_trailer {
 #else
 #error "Please fix <asm/byteorder.h>"
 #endif
-       u16 csum_start_offset;
-       u16 csum_length;
+       __be16 csum_start_offset;
+       __be16 csum_length;
        __be16 csum_value;
 } __aligned(1);