platform/x86: dell_rbu: Simplify cleanup code in create_packet()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 28 Jan 2020 21:32:13 +0000 (23:32 +0200)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 10 Feb 2020 15:47:38 +0000 (17:47 +0200)
The code looks more nicer if we use:
while (idx--)
instead:
for (;idx>0;idx--)

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/dell_rbu.c

index 4e044fc..416a7db 100644 (file)
@@ -199,12 +199,10 @@ static int create_packet(void *data, size_t length)
 
 out_alloc_packet_array:
        /* always free packet array */
-       for (;idx>0;idx--) {
+       while (idx--) {
                pr_debug("freeing unused packet below floor 0x%lx.\n",
-                       (unsigned long)virt_to_phys(
-                               invalid_addr_packet_array[idx-1]));
-               free_pages((unsigned long)invalid_addr_packet_array[idx-1],
-                       ordernum);
+                       (unsigned long)virt_to_phys(invalid_addr_packet_array[idx]));
+               free_pages((unsigned long)invalid_addr_packet_array[idx], ordernum);
        }
        kfree(invalid_addr_packet_array);