HID: propagate return value correctly in hid_input_report()
authorJiri Kosina <jkosina@suse.cz>
Wed, 10 Aug 2011 12:02:59 +0000 (14:02 +0200)
committerJiri Kosina <jkosina@suse.cz>
Wed, 10 Aug 2011 12:02:59 +0000 (14:02 +0200)
Fix a return value propagation that was omitted in David Herrmann's
locking fix around hid_input_report().

Reported-by: David Herrmann <dh.herrmann@googlemail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-core.c

index f9cff93..bf1f740 100644 (file)
@@ -1086,7 +1086,7 @@ int hid_input_report(struct hid_device *hid, int type, u8 *data, int size, int i
        struct hid_report *report;
        char *buf;
        unsigned int i;
-       int ret;
+       int ret = 0;
 
        if (!hid)
                return -ENODEV;
@@ -1145,7 +1145,7 @@ nomem:
 
 unlock:
        up(&hid->driver_lock);
-       return 0;
+       return ret;
 }
 EXPORT_SYMBOL_GPL(hid_input_report);